KarpelesLab / strtotime / 24115334784

81%

Build Type

push

github

Committed by MagicalTux

Commit Message

Achieve 100% PHP strtotime() compatibility with zero skips

Replace per-test PHP subprocess cross-checks with standalone PHP
validation scripts (check_csv_values.php, rebuild_csv.php). Remove
php_crosscheck_test.go — all PHP validation now runs via:
  php testdata/check_csv_values.php

Fix all remaining PHP compatibility issues:
- Extreme negative years: compute Unix timestamp using PHP's int64
  overflow arithmetic (phpEpochDays/phpUnixTimestamp/fixOverflowedTime)
- Years > 9999: reject in ISO parser, add parseLargeYearAsTime that
  matches PHP's compact time interpretation (10000→10:00:0)
- "March 1 eighth day 2009": treat trailing 4-digit number as military
  time (20:09) when month context already established
- "11Oct" compact DDMon: use base year instead of current year by
  threading now through parseDayMonthYear
- "2023-W01-8": treat day >= 8 as timezone offset matching PHP
- "sixth Monday of January 2023": expand ordinal support through
  twelfth, allow weekday overflow into next month
- "third/fifth day of": reject ordinal day-of-month beyond first/last
- "@timestamp.123456789": reject >6 fractional digits matching PHP
- "2023-W3": require 2-digit week numbers matching PHP
- "0000-00-00": use time.Date(0, 0, 0, ...) matching PHP's -0001-11-30

Result: 684 PHP-validated test cases, 0 failures, 0 skips.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

133 of 167 new or added lines in 5 files covered. (79.64%)

9 existing lines in 3 files now uncovered.

2845 of 3453 relevant lines covered (82.39%)

179.21 hits per line