stacklok / toolhive / 24088984050

65%

Build Type

push

github

Committed by web-flow

Commit Message

Validate volume mount source paths before spawning workload (#4568)

* Validate volume mount source paths before spawning workload

When a user specifies a nonexistent host path in --volume, the error
was only visible in proxy logs after the workload entered error state.
Add pre-flight os.Stat validation in processVolumeMounts (CLI context
only) so the error surfaces immediately at the CLI.

Fixes #2485

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix existing volume mount tests to use real temp directories

The pre-flight path validation now rejects nonexistent source paths,
so existing tests that used fake paths like /host need real directories.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix remaining volume test using hardcoded /host path

TestRunConfigBuilder also used a fake /host:/container volume that
the new pre-flight validation rejects. Use t.TempDir() like the
other volume tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Dan Barr <6922515+danbarr@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

7 of 13 new or added lines in 1 file covered. (53.85%)

18 existing lines in 3 files now uncovered.

54711 of 83925 relevant lines covered (65.19%)

63.27 hits per line