agama-project / agama / 24087024463

77%

master: 77%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): network connection form UX (part 6) (#3353)

Built on top of https://github.com/agama-project/agama/pull/3352, this
PR fixes a small but noticeable UX gap found while recording the
screencast for the referenced PR: when switching between "Chosen by
name" and "Chosen by MAC" binding modes, the device selection was lost
and the user had to re-pick it.

To fix it, one of the components has gained the ability to trigger
listeners on demand, making it possible to wire the two different
selectors instantiated under the hood and keep them in sync. Note that
although only one instance is mounted at a time and there is no real
risk of listener loops, `dontRunListeners: true` is still passed to the
`setFieldValue` call inside the listener as a safety net.


Related to:


* https://tanstack.com/form/latest/docs/framework/react/guides/listeners
* https://github.com/TanStack/form/pull/1680
* https://github.com/TanStack/form/pull/2104

Coverage Stats

3521 of 5573 branches covered (63.18%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

21259 of 26581 relevant lines covered (79.98%)

95.81 hits per line