Unleash / unleash / 24076561330

87%

master: 91%

push

github

chore: lint "useExhaustiveDependencies" for frontend/src/component/common/ and fix issues (#11732)

Enables https://biomejs.dev/linter/rules/use-exhaustive-dependencies/
for everything in frontend/src/component/common/ directory.

1. Lint flags a warning to a missing dependency (so useEffect can invoke
a stale/old function)
2. But, adding some of them can be tricky as they change on every render
3. So to fix the warning while not making the performance worse (or
introduced bugs) they now need to be a lot more stable.

It's really hard to test them so it's mostly based on my discussions
with Claude.

I did manual testing and didn't notice anything wrong. 

I followed this plan:

Testing I did: 

> # Manual Test Plan — `sa-321/bime-lint` branch
> 
> This branch lints `useExhaustiveDependencies` across
`frontend/src/component/common/` and fixes the resulting issues. The
changes are comment-only in most places, but several files have real
behavioral changes to `useEffect` and `useMemo` dependency arrays. Test
each section below to confirm no regressions.
> 
> ---
> 
> ## 1. Feature Archive Dialog
> 
> **Risk:** High — `verifyArchiveFeatures` was added to effect deps; the
effect drives disable/enable of the confirm button.
> 
> ### Setup
> 1. Create a project (or use an existing one).
> 2. Create a feature flag **parent** (e.g. `parent-feature`).
> 3. Create a feature flag **child** (e.g. `child-feature`) and add a
dependency on `parent-feature`:
> - Open `child-feature` → **Dependencies** tab → add `parent-feature`
as a prerequisite.
> 4. Create a third flag **standalone** (e.g. `standalone-feature`) with
no dependencies.
> 
> ### Tests
> 
> #### A — Archive a flag with no dependencies
> 1. Go to the project's feature list.
> 2. Select `standalone-feature` → click **Archive**.
> 3. **Expected:** Dialog opens, confirm button is **enabled**, no
warning about dependencies.
> 4. Confirm archive → flag moves to archived state.
> 
> #### B — Archive a parent th... (continued)

1820 of 2012 branches covered (90.46%)

14971 of 17194 relevant lines covered (87.07%)

904.85 hits per line