KarpelesLab / pktkit / 23979011789
53%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 48
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 45.692% (-1.0%) from 46.7%
23979011789

push

github

MagicalTux 
Fix 35 bugs across all packages found via code audit

vtcp: clamp remote WScale to 14 (RFC 7323), fix sendBufSize ignoring
config, use probe interval for keepalive (not idle), re-ACK in CLOSING
state, use zero-padding after options (RFC 793).

root: validate DHCP REQUEST IPs against pool/conflicts, dynamic reply
buffer sizing, skip lease time for INFORM, fix renewal to use unicast
with correct source IP (RFC 2131), fix data race on offeredIP/serverIP
in timer, fix NDP DAD response (RFC 4861: unspecified source handling,
solicited flag, all-nodes multicast), only intercept port 68 when DHCP
active, fix ARP/NDP lookup TOCTOU on expiry delete, add bounds checks
to SetDstMAC/SetSrcMAC.

nat: remove spurious allocPort in expectation path (port leak), use
atomic.Pointer for defragger (data race), rewrite sipRewriteHeader to
respect prefix parameter, scope bare-IP replacement to SIP headers only,
fix Content-Length "l:" false positive matching, loop for even RTP port
allocation, add IPv6 extension header walking in NAT64, fix ICMPv4
Protocol Unreachable mapping to ICMPv6 Parameter Problem (RFC 6145),
reject overlapping fragments (RFC 5722), enforce 65535-byte reassembly
limit, reject port forward hijacking across inside clients, add PPTP
call map cleanup.

slirp: pass transportOff to ICMPv6/UDP6 handlers (extension header
support), clamp TCP data offset to prevent RST ACK number underflow,
drain and abort queued connections on listener close, check closeCh
in accept select.

vclient: send RST packets from Abort() instead of discarding them,
check listener closeCh in accept path, fix allocPort TOCTOU with
reservedPorts set, return net.ErrClosed from UDPConn.Read, validate
DNS label length <= 63 bytes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

98 of 397 new or added lines in 24 files covered. (24.69%)

13 existing lines in 5 files now uncovered.

3977 of 8704 relevant lines covered (45.69%)

10.51 hits per line

Uncovered Changes

Lines Coverage ∆ File
58
0.0
 0.0% nat/alg_sip.go
48
0.0
 0.0% nat/nat64.go
46
71.33
 -11.93% dhcp.go
27
41.81
 -5.58% vclient/tcp.go
13
75.44
 -3.43% dhcpd.go
12
53.16
 -1.42% l2adapter.go
12
0.0
 0.0% nat/defrag.go
11
70.69
 0.31% nat/nat.go
11
55.91
 -0.45% vtcp/conn.go
10
39.5
 -0.86% vclient/dns.go
9
62.45
 -2.1% slirp/ipv6.go
9
62.44
 -1.35% slirp/usernat.go
7
0.0
 0.0% nat/alg_pptp.go
4
74.55
 -1.38% arp.go
4
94.37
 -5.63% frame.go
4
23.91
 -0.71% nat/helper.go
4
1.78
 -0.02% ndp.go
2
79.63
 -3.39% slirp/icmpv6.go
2
82.4
 0.26% slirp/listener.go
2
51.84
 0.16% vclient/client.go
2
46.71
 0.08% vclient/dial.go
2
37.72
 0.0% vclient/udp.go

Coverage Regressions

Lines Coverage ∆ File
3
75.44
 -3.43% dhcpd.go
3
70.69
 0.31% nat/nat.go
3
51.84
 0.16% vclient/client.go
3
55.91
 -0.45% vtcp/conn.go
1
41.81
 -5.58% vclient/tcp.go
Jobs
ID Job ID Ran Files Coverage
1 23979011789.1 48
45.69
 GitHub Action Run
Source Files on build 23979011789