kobotoolbox / kpi / 23954362374

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(massEmails): do not disable emails before they are sent DEV-1953 (#6915)

### 📣 Summary
Fixes a bug that was disabling one-time email sends before they could be
sent.


### 📖 Description
When users created one-off emails after the daily send lists had been
generated, they were automatically getting turned off (having `Live` set
to False) before they could actually be sent.


### 💭 Notes

Eventually we probably want to show the users in Django admin if we
tried to send a one-off email but there were no recipients, but we don't
have a good mechanism yet for saving those errors and adding one is
beyond the scope of this more urgent fix.
We still keep empty MassEmailJobs around because they are the only
persisted record of when we tried to send an email, whether or not any
emails were generated.

### 👀 Preview steps
Note: recreation of the bug is very finicky and very much based on
timing

Make sure `MASS_EMAILS_CONDENSE_SEND` is True. Remember to restart the
kpi worker in after switching branches.

1. Add test users to `MASS_EMAIL_TEST_EMAILS` in Constance
2. Create a new `MassEmailConfig` Test1 that uses `test_users` and has
frequency = 1 and set it live. This is just so
generate_mass_send_emails() will always have something to generate. Wait
5 m to ensure a send list gets generated.
3. Create another `MassEmailConfig` Test2 that uses the `test_users`
query and has frequency = -1. Do not set it live yet.
4. at least 2 minutes past and 6 minutes before a 15 minute boundary,
set Test2 email live (eg at 1:02-1:09, 1:17-1:24, 1:32-1:39, 1:47-1:54).
5. Wait at least 5 minutes 
6. Open the config in Django admin
7. 🔴 [on main] The config is no longer live even though no emails have
been sent
8. 🟢 [on PR] The config is still live
9. 🟢 At the next 15 minute boundary, the one-time email sends

Coverage Stats

7441 of 11558 branches covered (64.38%)

0 of 5 new or added lines in 1 file covered. (0.0%)

27 existing lines in 4 files now uncovered.

28561 of 34951 relevant lines covered (81.72%)

5.81 hits per line