KarpelesLab / slirp / 23944942133

71%

Build Type

push

github

Committed by MagicalTux

Commit Message

Remove dead code: old TCP implementations replaced by vtcp

Phase 3.4 cleanup: Delete all code that has been superseded by vtcp.Conn.

Removed files:
- tcp.go (406 lines): old tcpConn IPv4 NAT proxy
- tcp6.go (392 lines): old tcpConn6 IPv6 NAT proxy
- tcp_test.go (1097 lines): tests for old tcpConn
- tcp6_test.go (639 lines): tests for old tcpConn6

Removed from listener.go (331→19 lines):
- VirtualConn type and all methods (Read, Write, Close, flush,
  handleInbound, newVirtualConn, SetDeadline*)
- BuildTCPPacket helper (now in frame.go as buildFrame4)

Removed from listener6.go (290→7 lines):
- VirtualConn6 type and all methods
- BuildTCPPacket6 helper (now in frame.go as buildFrame6)

Added:
- test_helpers_test.go: shared test utilities (createTCPPacket,
  createTCPPacket6, bytesEqual) extracted from deleted test files
- itoaU16 moved to usernat.go (was in deleted tcp.go)

Net result: -3012 lines. The three ad-hoc TCP implementations are fully
replaced by the single vtcp.Conn engine.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

25 of 29 new or added lines in 2 files covered. (86.21%)

1 existing line in 1 file now uncovered.

2449 of 3327 relevant lines covered (73.61%)

7.47 hits per line