KarpelesLab / slirp / 23944870087

71%

Build Type

push

github

Committed by MagicalTux

Commit Message

Replace vclient.TCPConn with vtcp.Conn wrapper

Phase 3.3: The vclient TCP implementation (800+ lines of ad-hoc state
machine, retransmission, congestion control) is replaced by a thin
wrapper around vtcp.Conn.

TCPConn is now 6 methods delegating to vtcp.Conn + unregistration logic.
dialTCP creates a vtcp.Conn and calls Connect(ctx). handleTCP parses
segments and delegates to HandleSegment.

Removed 1693 lines of duplicated TCP implementation:
- Old state machine (tcpState, handleSegment, processACK)
- Old retransmission (onRTOTimeout, startRTO, stopRTO, updateRTO)
- Old keepalive (keepaliveLoop, buildKeepaliveProbe)
- Old segment builders (buildSYN, buildACK, buildFIN, buildDataSegment)
- Old IP packet builder (buildIPPacket)
- All internal tests for the old implementation (keepalive_test.go,
  tcp_internal_test.go) — this functionality is now tested in
  vtcp/conn_test.go

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

56 of 65 new or added lines in 2 files covered. (86.15%)

6 existing lines in 3 files now uncovered.

2904 of 4345 relevant lines covered (66.84%)

8.62 hits per line