pantsbuild / pants / 23925300352

93%

push

github

Port ScalarField, AsyncFieldMixin and friends to rust (#23204)

The real juice is in porting `SourcesField` and what that unlocks. This
is a stepping stone, hopefully worth the squeeze.

This additionally marks Field as frozen, allowing to avoid additional
ref-counting overhead.

Still noticable in our 26k python, 100 JS file file repo
```console
hyperfine --warmup 1 --runs 3 \                                                         
        -n 'main' \                                                                                                             
        --prepare 'git -C <redacted>/pants checkout main --quiet' \                                                      
        'PANTS_SOURCE=<redacted>/pants PYENV_VERSION=pants@3.14.3 pants --no-pantsd dependencies :: > /dev/null' \     
        -n 'branch' \                                                                                                           
        --prepare 'git -C <redacted>/pants checkout add/port-scalar-and-async-mixin-fields --quiet' \                  
        'PANTS_SOURCE=<redacted>/pants PYENV_VERSION=pants@3.14.3 pants --no-pantsd dependencies :: > /dev/null' \     
        2>&1)
  ⎿  Benchmark 1: main
       Time (mean ± σ):     35.261 s ±  1.261 s    [User: 40.704 s, System: 12.371 s]
       Range (min … max):   34.021 s … 36.542 s    3 runs
      
     Benchmark 2: branch                                                                                                        
       Time (mean ± σ):     33.615 s ±  0.202 s    [User: 38.675 s, System: 12.403 s]
       Range (min … max):   33.478 s … 33.847 s    3 runs      
```

12 of 12 new or added lines in 2 files covered. (100.0%)

91532 of 98519 relevant lines covered (92.91%)

4.04 hits per line