orneryd / NornicDB / 23917549797

89%

Build Type

push

github

Committed by orneryd

Commit Message

fix: remove embedding property namespace pollution and fix ORDER BY
  Remove special-case routing that intercepted the "embedding" property
  name during SET/GET operations, redirecting it to internal
  ChunkEmbeddings storage. The "embedding" property is now treated as a
  regular user property stored in node.Properties — users can name their
  embedding fields anything and create vector indexes for them.
  Changes:
  - set_helpers.go: Remove SET n.embedding interception to ChunkEmbeddings
  - node_helpers.go: Remove buildEmbeddingSummary injection into node maps
  - functions_eval_props_literals.go: Remove embedding read routing
  - executor_subqueries.go: Remove embedding read routing, add
    []interface{} array formatting for CALL parameter substitution
  - executor_mutations_where_eval.go: Remove embedding IS NULL routing
  - comparison.go: Remove embedding IS NULL/IS NOT NULL routing
  - executor_subqueries.go: Fix ORDER BY on non-projected node properties
    (e.g. ORDER BY t.createdAt when only t is returned)
  - Update system-design.md, vector-search.md, troubleshooting.md to
    reflect correct defaults (8192 chunk size, bge-m3 model) and
    WITH EMBEDDING support
  - Update all affected tests to assert current behavior

Coverage Stats

28 of 52 new or added lines in 4 files covered. (53.85%)

106 existing lines in 9 files now uncovered.

109855 of 127810 relevant lines covered (85.95%)

1.0 hits per line