orioledb / orioledb / 23907489513
90%
main: 90%

LAST BUILD BRANCH: harden-checkpoint-no-test
DEFAULT BRANCH: main
Ran
Jobs 1
Files 92
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 90.251% (-0.04%) from 90.287%
23907489513

push

github

za-arthur 
recovery: simplify WAL reader

Container flags (WAL_CONTAINER_HAS_XACT_INFO,
WAL_CONTAINER_HAS_ORIGIN_INFO)
are now parsed inline in parse_wal_container() directly into two new
fields on WalReaderState (xactTime, xactXid) instead of going through
a descriptor table, a per-flag helper function, and an on_flag callback.

At all three call sites the separate *_wal_check_version and
*_wal_container_info callbacks are merged:

  - replay_wal_containter_info() is folded into
replay_wal_check_version();
    recoveryHeapTransactionId is assigned there from r->xactXid.
  - decode_wal_containter_info() is removed; has_origin is dropped from
    DecodeWalDescCtx and replaced by a direct rec->origin_id check in
    decode_wal_record().
  - recovery_wal_containter_info() is removed; the stops hook reads
    xactTime/xactXid from WalReaderState after parse_wal_container()
    returns.

g_wal_descs[] is rewritten using designated initialisers with a
per-entry
comment on the opening brace, matching the style of sysTreesMeta in
src/catalog/sys_trees.c. Each .parse field is now a direct function
reference that LSP can follow with go-to-definition.

The ORIOLE_WAL_RECORDS X-macro and the OrioleWalRecType enum generated
from it are removed as they had no remaining consumers. WAL_REC_*
constants are now plain #defines.

Book-length block comments in parse_wal_container() and the removed
helper functions are replaced with concise prose.

45620 of 50548 relevant lines covered (90.25%)

49034402.88 hits per line

Coverage Regressions

Lines Coverage ∆ File
157
91.05
 0.02% orioledb/src/recovery/recovery.c
85
77.72
 0.0% orioledb/src/orioledb.c
46
89.88
 0.49% orioledb/src/recovery/logical.c
17
91.32
 0.83% orioledb/src/recovery/wal.c
17
84.11
 -0.78% orioledb/src/recovery/wal_reader.c
14
90.55
 -1.39% orioledb/src/btree/scan.c
5
85.88
 -0.26% orioledb/src/btree/io.c
5
92.02
 -1.33% orioledb/src/btree/merge.c
5
91.08
 -0.09% orioledb/src/checkpoint/checkpoint.c
3
97.11
 -0.26% orioledb/src/tableam/descr.c
3
93.7
 -0.14% orioledb/src/transam/undo.c
2
91.16
 -0.08% orioledb/src/catalog/ddl.c
2
93.17
 -0.15% orioledb/src/catalog/o_sys_cache.c
1
93.62
 0.15% orioledb/src/catalog/o_tables.c
1
92.16
 0.45% orioledb/src/s3/headers.c
1
78.1
 -0.73% orioledb/src/s3/queue.c
Jobs
ID Job ID Ran Files Coverage
1 23907489513.1 92
90.25
 GitHub Action Run
Source Files on build 23907489513