23842752611
90%

Ran 01 Apr 2026 11:08AM UTC

Jobs 1

Files 92

Run time 1min

Badge

Embed ▾

Committed 01 Apr 2026 09:51AM UTC coverage: 90.287% (-0.01%) from 90.299%

Build # 23842752611

Build Type

push

github

Committed by

akorotkov

Commit Message

Relax undo cleanup assertion to account for recovery retain locations

During recovery, apply_xids_record() replays transaction records from
the previous checkpoint's xid file.  Transactions that were in-progress
during that checkpoint have their retain locations in the
[checkpointRetainStartLocation, checkpointRetainEndLocation] range.
These get loaded into minProcRetainLocation, which can push it below
cleanedLocation (initialized from the control file's lastUndoLocation).

This caused the Assert(oldCleanedNum <= newCleanedNum) in
update_min_undo_locations() to fire during end-of-recovery checkpoint,
because minRetainLocation (used as the new cleaned location) could be
in a lower undo file than the old cleaned location.

The undo files in the checkpoint retain range were persisted during the
previous checkpoint and were never cleaned, so it is safe for the
cleaned location to move back into that range.  Relax the assertion to
allow newCleanedNum < oldCleanedNum as long as newCleanedNum is within
the old checkpoint retain range (>= oldCheckpointStartNum).

Assisted-by: Claude Opus 4.6

Coverage Stats

45705 of 50622 relevant lines covered (90.29%)

77891956.59 hits per line

Coverage Regressions

Lines	Coverage	∆	File
170	91.03	-0.52%	orioledb/src/recovery/recovery.c
115	88.38	-0.14%	orioledb/src/tableam/handler.c
78	93.84	0.07%	orioledb/src/transam/undo.c
34	92.85	0.02%	orioledb/src/catalog/o_indices.c
20	97.36	0.01%	orioledb/src/tableam/descr.c
16	97.26	0.02%	orioledb/src/recovery/worker.c
14	90.63	-1.28%	orioledb/src/btree/find.c
7	93.48	-0.51%	orioledb/src/catalog/o_tables.c
5	90.49	0.0%	orioledb/src/recovery/wal.c
3	90.01	-0.43%	orioledb/src/tableam/vacuum.c
2	70.86	-0.49%	orioledb/src/btree/fastpath.c
2	91.7	0.45%	orioledb/src/s3/headers.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	23842752611.1	01 Apr 2026 11:08AM UTC	92	90.29	GitHub Action Run

orioledb / orioledb / 23842752611
90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 23842752611

orioledb / orioledb / 23842752611 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 23842752611

orioledb / orioledb / 23842752611
90%

README BADGES
x