grpc / grpc-java / #20232
89%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 646
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.784% (+0.03%) from 88.755%
#20232

push

github

web-flow 
xds: Add configuration objects for ExtAuthz, GrpcService and Bootstrap changes for GrpcService (#12492)

This commit introduces configuration objects for the external
authorization (ExtAuthz) filter and the gRPC service and corresponding
translations from XDS proto and Bootstrap. These classes provide a
structured, immutable representation of the subset of the configuration
defined in the xDS protobuf messages.

This PR should mostly now (hopefully ) be compliant with
https://github.com/grpc/proposal/pull/510 but without
- CallCredentials (since I don't see A97) being implemented yet and
would prefer to do it in a followup , we return empty optional)
- TlsCredentials( since it's non trivial to construct a TLS credentials
object, we throw an exception)
- LocalCredentials(Java does't support these, we throw an exception)

The main new classes are:
- `ExtAuthzConfig`: Represents the configuration for the `ExtAuthz`
filter, including settings for the gRPC service, header mutation rules,
and other filter behaviors.
- `GrpcServiceConfig`: Represents the configuration for a gRPC service,
including the target URI, credentials, and other settings.
- `HeaderMutationRulesConfig`: Represents the configuration for header
mutation rules.
- `ChannelCredsConfig` and friends: To allow comparison between
credential configuration , to allow caching based on creds which'll be
needed in followup PRs for authz and proc.

The relevant sections of the spec are 
- GrpcService: https://github.com/grpc/proposal/pull/510
- ExtAuthz:
https://github.com/grpc/proposal/pull/481/files#diff-6bb76a24ad2fd8849f164244e68cd54eaR106-R190

This commit also includes parsers to create these configuration objects
from the corresponding protobuf messages, as well as unit tests for the
new classes.

35968 of 40512 relevant lines covered (88.78%)

0.89 hits per line

Coverage Regressions

Lines Coverage ∆ File
17
79.57
 -5.34% ../xds/src/main/java/io/grpc/xds/GrpcBootstrapperImpl.java
8
94.7
 -0.57% ../xds/src/main/java/io/grpc/xds/client/BootstrapperImpl.java
4
74.23
 -4.12% ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
4
91.9
 -1.9% ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
1
90.77
 -0.26% ../core/src/main/java/io/grpc/internal/ClientCallImpl.java
1
88.14
 0.4% ../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1
87.88
 -3.03% ../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
1
94.44
 0.33% ../xds/src/main/java/io/grpc/xds/client/Bootstrapper.java
1
96.55
 -1.72% ../xds/src/main/java/io/grpc/xds/internal/security/certprovider/CertificateProvider.java
Jobs
ID Job ID Ran Files Coverage
1 #20232.1 646
88.78
Source Files on build #20232