hyperledger-labs / fabric-smart-client / 23854927652
66%

DEFAULT BRANCH: main
Ran
Jobs 15
Files 535
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 65.529% (+0.5%) from 65.009%
23854927652

push

github

web-flow 
chore(view_service): refactoring and clenaup #967 (#1185)

* refactoring

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* chore(view): fix linting issues by checking error return values in tests

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* lint fix

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* race condition fix

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* additional refactoring

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* cleanup

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* removed context.Context as field of the Manager

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

# Conflicts:
#	platform/view/sdk/dig/sdk.go

* cleanup

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* cleanup

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* fix unit-tests

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* print stack with invoking view

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* remove context cleanup

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* helper functions

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* documentation

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* documentation

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* more logging

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* rebase fix

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* fix sdk

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* refactoring

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

* dig fix

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

---------

Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>

409 of 520 new or added lines in 33 files covered. (78.65%)

25 existing lines in 10 files now uncovered.

25844 of 39439 relevant lines covered (65.53%)

3189.07 hits per line

Uncovered Changes

Lines Coverage ∆ File
14
58.74
 -0.54% platform/view/services/view/grpc/server/view.go
11
87.21
 platform/view/services/view/p2p/service.go
8
48.39
 0.56% platform/view/services/view/web/view.go
7
78.08
 -7.4% platform/view/services/comm/host/websocket/server.go
6
81.25
 -3.51% platform/view/services/comm/host/websocket/host.go
6
91.01
 21.7% platform/view/services/view/manager.go
6
87.5
 -8.86% platform/view/services/view/sp.go
6
83.93
 21.77% platform/view/services/view/view.go
4
71.13
 -1.81% platform/view/services/comm/service.go
4
0.0
 0.0% platform/view/services/comm/test_utils.go
4
0.0
 0.0% platform/view/services/view/grpc/client/local.go
4
0.0
 0.0% platform/view/services/view/grpc/client/stream.go
4
93.65
 7.38% platform/view/services/view/sessions.go
4
71.43
 -28.57% platform/view/services/view/wrapper.go
3
82.72
 -3.18% platform/view/services/comm/master.go
3
73.33
 0.0% platform/view/services/view/grpc/server/ac.go
3
78.57
 0.0% platform/view/services/view/grpc/server/server.go
3
94.04
 25.69% platform/view/services/view/registry.go
2
84.15
 -1.93% platform/view/sdk/dig/sdk.go
2
0.0
 0.0% platform/view/services/comm/io/test_utils.go
2
54.6
 0.0% platform/view/services/view/grpc/client/client.go
1
74.87
 -0.38% platform/view/services/comm/host/websocket/config.go
1
0.0
 0.0% platform/view/services/comm/sessions_test_utils.go
1
92.39
 20.78% platform/view/services/view/context.go
1
65.55
 0.0% platform/view/services/view/grpc/client/cmd/view.go
1
63.01
 -0.88% platform/view/services/web/server/stream.go

Coverage Regressions

Lines Coverage ∆ File
9
50.98
 -17.65% platform/common/utils/collections/maps/utils.go
3
50.0
 -25.0% platform/view/services/storage/driver/sql/postgres/errormapper.go
2
91.01
 21.7% platform/view/services/view/manager.go
2
87.5
 -8.86% platform/view/services/view/sp.go
2
89.35
 -0.59% platform/view/services/comm/p2p.go
2
87.17
 -1.07% platform/view/services/comm/session.go
2
83.93
 21.77% platform/view/services/view/view.go
1
81.25
 -3.51% platform/view/services/comm/host/websocket/host.go
1
58.74
 -0.54% platform/view/services/view/grpc/server/view.go
1
71.13
 -1.81% platform/view/services/comm/service.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fsc-pingpong - 23854927652.1 274
31.86
 GitHub Action Run
2 itest-fsc-stoprestart - 23854927652.2 274
30.23
 GitHub Action Run
3 utest-postgres - 23854927652.3 534
7.5
 GitHub Action Run
4 itest-fabric-atsa - 23854927652.4 478
41.76
 GitHub Action Run
5 itest-fabricx-multiendorsement - 23854927652.5 508
26.46
 GitHub Action Run
6 itest-fabric-twonets - 23854927652.6 478
28.27
 GitHub Action Run
7 itest-fabric-atsachaincode - 23854927652.7 483
29.22
 GitHub Action Run
8 itest-fabric-stoprestart - 23854927652.8 478
30.17
 GitHub Action Run
9 itest-fabric-iou - 23854927652.9 478
39.95
 GitHub Action Run
10 itest-fabricx-iou - 23854927652.10 508
26.9
 GitHub Action Run
11 itest-fabric-iouhsm - 23854927652.11 478
39.33
 GitHub Action Run
12 itest-fabricx-deployment - 23854927652.12 508
26.34
 GitHub Action Run
13 itest-fabric-events - 23854927652.13 483
26.68
 GitHub Action Run
14 utest - 23854927652.14 534
40.35
 GitHub Action Run
15 itest-fabricx-simple - 23854927652.15 508
25.39
 GitHub Action Run
Source Files on build 23854927652