Unleash / unleash / 23802564289

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix: do not propagate unrelated changes to other envs (#11660)

## About the changes
This fixes a bug in delta / streaming propagation where a feature change
in one environment could produce a `feature-updated` event in other
connected environments, even when those environments had no in-scope
change.

The issue was in `ClientFeatureToggleDelta.updateFeaturesDelta()`. It
built one global set of changed feature names for the revision window
and then, for every connected environment, reloaded those feature names
in that environment and emitted `feature-updated` events.

That meant a change in `production` could cause a client streaming
`development` to receive:
- a new `eventId`
- a `feature-updated` payload containing the current `development` state
- no actual change for the subscribed environment

So, from the client's point of view, this looked like a no-op update
with a bumped revision.

This PR narrows feature refreshes by environment before reloading
toggles:
- environment-specific events only refresh the matching connected
environment
- environment-agnostic events still apply to all environments
- segment and removal behavior stay unchanged

I also added a regression test covering the case where a production-only
feature update must not emit a synthetic development delta event.

## Discussion points
This is intentionally the smaller correctness fix.

A possible follow-up would be to precompute affected environments and
skip unaffected delta caches entirely, but that is not required to fix
the incorrect payload propagation described above.

Run Details

1820 of 2012 branches covered (90.46%)

29 of 33 new or added lines in 1 file covered. (87.88%)

2 existing lines in 2 files now uncovered.

14963 of 17181 relevant lines covered (87.09%)

888.91 hits per line