IJHack / QtPass / 23795245986

21%

master: 7%

Build Type

push

github

Committed by web-flow

Commit Message

Fix memory leak in QR code popup dialog (#863)

* Fix memory leak in QR code popup dialog

The QDialog created in showTextAsQRCode() was never deleted after
exec() returned, causing a memory leak.

Fix by adding Qt::WA_DeleteOnClose attribute to ensure the dialog
is deleted when closed.

* 📝 CodeRabbit Chat: Add unit tests for changes

* test: remove flaky QR popup auto-deletion test

The qrCodePopupDeletesItselfOnClose test was unreliable - WA_DeleteOnClose
does not guarantee immediate deletion on Qt::Popup windows. The remaining
tests verify:
- Attribute is correctly set (qrCodePopupHasDeleteOnCloseAttribute)
- Without attribute, no auto-deletion occurs

Also fixed clang-format formatting on CodeRabbit's test additions.

* test: add QR popup auto-deletion test using QTRY_VERIFY

The QTRY_VERIFY macro handles the asynchronous nature of Qt::WA_DeleteOnClose
deletion, making the test reliable across different platforms.

Test verifies that a QDialog with Qt::Popup | Qt::FramelessWindowHint
and WA_DeleteOnClose attribute is properly deleted when close() is called.

* test: add codecov coverage for QR popup createQRCodePopup

Extract createQRCodePopup as a static public method to enable direct
testing. This provides codecov coverage for the memory leak fix line
popup->setAttribute(Qt::WA_DeleteOnClose) in showTextAsQRCode.

The test verifies that QtPass::createQRCodePopup creates a QDialog
with Qt::WA_DeleteOnClose attribute set.

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Coverage Stats

12 of 13 new or added lines in 1 file covered. (92.31%)

58 existing lines in 1 file now uncovered.

931 of 5039 relevant lines covered (18.48%)

7.66 hits per line