• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

hyperledger / fabric-x-committer / 23794732970
91%
main: 92%

Build:
Build:
LAST BUILD BRANCH: extract-prometheus-startup-and-grpc-server-start
DEFAULT BRANCH: main
Ran 31 Mar 2026 11:28AM UTC
Jobs 2
Files 124
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

31 Mar 2026 11:20AM UTC coverage: 91.391% (+0.2%) from 91.198%
23794732970

Pull #501

github

cendhu
[test] fix flaky TestSignatureVerifierManagerPolicyUpdateAndRecover

Root cause: requireAllUpdate submits many batches (3 per 10ms tick),
filling the outputValidatedTxs channel (capacity 10). When the channel
is full, signVerifier goroutines block on Write() instead of being in
Recv(). Both goroutines in the errgroup deadlock: receiveStatus blocks
on Write (channel full), sendTransactions blocks on Read (no batches),
and neither can cancel gCtx. The drain goroutine was started after
requireAllUpdate, so the channel was already full by the time it ran.
On busy CI machines, the drain goroutine's scheduling delay combined
with buffered responses meant signVerifier[0] could remain stuck on
Write for the entire 30-second EventuallyIntMetric timeout, never
reaching Recv() to detect the broken stream from server.Stop().

Fix: move the drain goroutine before requireAllUpdate so the output
channel never fills up. This ensures signVerifiers are always in their
idle state (blocked on Recv) when the server stops, allowing immediate
stream break detection. Use channel.Ready to guarantee the drain
goroutine is running before proceeding.

Signed-off-by: Senthilnathan <cendhu@gmail.com>
Pull Request #501: [test] fix flaky TestSignatureVerifierManagerPolicyUpdateAndRecover

9936 of 10872 relevant lines covered (91.39%)

42282.43 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
86.24
-3.67% loadgen/adapters/broadcast.go
2
89.75
-0.62% mock/orderer.go
2
92.2
-0.92% service/coordinator/signature_verifier_manager.go
Jobs
ID Job ID Ran Files Coverage
1 unit-test - 23794732970.1 31 Mar 2026 11:37AM UTC 79
75.33
GitHub Action Run
2 db-test - 23794732970.2 31 Mar 2026 11:28AM UTC 124
84.41
GitHub Action Run
Source Files on build 23794732970
  • Tree
  • List 124
  • Changed 15
  • Source Changed 0
  • Coverage Changed 15
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #501
  • PR Base - main (#23785829163)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc