Alan-Jowett / sonde / 23773692255

82%

push

github

test(gateway): implement T-1403, T-1404, T-1405a handler tests (#592)

* test(gateway): implement T-1403, T-1404, T-1405a handler tests

- T-1403: handler live-reload add — verify APP_DATA routes after \AddHandler\
- T-1404: handler live-reload remove — verify APP_DATA stops routing after \RemoveHandler\
- T-1405a: invalid YAML bootstrap — verify warning logged, valid entry imported

Also makes \load_handler_configs\ lenient: invalid entries are skipped
with a warning instead of failing the entire load (GW-1405).

Closes #589
Closes #590

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(gateway): update existing tests for lenient YAML loader

Existing tests expected load_handler_configs to return Err on invalid
entries, but GW-1405 requires lenient behavior (skip + warn). Updated
3 tests to expect Ok with empty results for invalid entries.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* style: fix formatting in handler tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review findings: live-reload tests, doc comments, warn logging

- T-1403: Use shared infrastructure (new_with_pending) and set_handler_router
  on the *same* gateway instance instead of creating a new one. Build the
  HandlerRouter from storage records after admin add_handler.

- T-1404: Use shared infrastructure (new_with_pending) and build router from
  storage records. After admin remove_handler, verify storage is empty and
  rebuild router from current state to confirm no routing.

- load_handler_configs: Update doc comment to document lenient semantics
  (invalid entries are skipped with a warning, only file I/O and YAML parse
  errors are fatal).

- Add path and command to the warn! structured fields when skipping invalid
  handler entries for easier diagnostics.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address iteration 2 findings: require_python macro, persiste... (continued)

28 of 28 new or added lines in 1 file covered. (100.0%)

23509 of 27616 relevant lines covered (85.13%)

153.44 hits per line