stacklok / toolhive / 23744823818

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix(mcp): disable interactive OAuth in embedded MCP server handler (#4444)

The MCP server handler was calling registry.GetDefaultProvider() without
explicitly setting WithInteractive(false). Because the registry provider
is a singleton (sync.Once), and the MCP handler is typically the first
caller during `thv serve --experimental-mcp`, it "poisoned" the shared
provider with interactive=true. All subsequent callers — including the
HTTP API routes that intentionally disable interactive mode — inherited
this setting, causing the browser to open for OAuth on every registry
access when credentials were invalid.

Made-with: Cursor

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

45 existing lines in 7 files now uncovered.

52637 of 80431 relevant lines covered (65.44%)

62.88 hits per line