Alan-Jowett / sonde / 23727109085
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 77
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.116%. Remained the same
23727109085

push

github

web-flow 
feat(installer): MSI service registration with COM port auto-detect (GW-1501) (#581)

* feat(installer): MSI service registration with COM port auto-detect (GW-1501)

- Add C# custom action (SondeCustomActions.dll) that scans USB devices
  for ESP32-S3 modem (VID 303A, PID 1001) via WMI + registry fallback
- Add ServiceInstall/ServiceControl elements to register sonde-gateway
  as an auto-start Windows service during MSI installation
- MODEM_PORT property auto-populated by custom action, editable in dialog
- Service ImagePath includes --service --port --db --master-key-file
- On uninstall: service stopped and removed, data files preserved
- On upgrade: service stopped before replacement, restarted after
- Update release.yml and nightly-release.yml to build custom action DLL

Implements: GW-1501
Relates-to: #524

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(installer): warn when no modem detected during MSI install

Shows an OK/Cancel warning dialog with diagnostics when the auto-detect
custom action fails to find an ESP32-S3 modem. Lists possible causes
and suggests sonde-gateway install --port as a reconfigure path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(installer): target net472 for WiX DTF custom action

WiX v4 DTF custom actions require .NET Framework, not .NET 8.
Fix package versions to 4.0.6 (matching WiX toolset version),
target net472, and update CI output paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(installer): address all 7 review findings

- MODEM_PORT marked Secure for UI→execute property flow
- ServiceInstall moved into GatewayExe component (shares KeyPath)
- Service NOT auto-started during install (master key may not exist)
- Custom action scheduled Before=CostFinalize (not ExecuteAction)
- ServiceGroup removed (merged into BinariesGroup)
- Log ex.ToString() instead of ex.Message for full diagnostics
- net472 target already fixed ... (continued)

23504 of 27614 relevant lines covered (85.12%)

153.43 hits per line

Jobs
ID Job ID Ran Files Coverage
1 23727109085.1 77
85.12
 GitHub Action Run
Source Files on build 23727109085