Alan-Jowett / sonde / 23723030432

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(gateway): implement error diagnostic observability (GW-1307) (#579)

* feat(gateway): implement error diagnostic observability (GW-1307)

Improve error messages across all user-facing boundaries to include
operation name, input parameters, subsystem error, and actionable
guidance where applicable.

Boundaries improved: serial port, admin API, program verification,
storage, key provider, state export/import.

Implements: GW-1307
Relates-to: #532

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(gateway): address review findings for GW-1307

- bundle_err: handle all BundleError variants explicitly with
  variant-specific guidance instead of a catch-all (GW-1307 AC2)
- import_state: delegate guidance to bundle_err instead of
  always appending generic passphrase/corruption text
- remove_program: replace storage_err with storage_err_with_context
  for list_nodes and delete_program calls (GW-1307 AC1)
- assign_program: add operation context, program hash, and
  actionable guidance to all error paths (GW-1307 AC1)
- queue_ephemeral: add operation context and profile details
  to all error paths (GW-1307 AC1)
- fmt_hex: use pre-sized String allocation instead of per-byte
  format! allocations
- modem: collapse duplicate UNKNOWN match arms to fix clippy
  match_same_arms warning
- modem: make guidance structured fields single-line to avoid
  any ambiguity about embedded whitespace
- tests: tighten assertions to require specific operation markers
  and actionable guidance text instead of overly permissive matches
- tests: use tempdir() for path-based tests to ensure hermiticity
  and cross-platform correctness

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address round-2 review findings

- Precompute \.to_string()\ before match in \storage_err_with_context\
  and \undle_err\ to avoid referencing moved value in format arms
- Add \alidate_program_hash_bytes\ helper enforcing 32-byte SHA-256
  length o... (continued)

Coverage Stats

101 of 271 new or added lines in 6 files covered. (37.27%)

6 existing lines in 2 files now uncovered.

23504 of 27614 relevant lines covered (85.12%)

153.43 hits per line