kubevirt / containerized-data-importer / #5923

50%

push

travis-ci

Fix snapshot clone watcher to re-trigger reconciliation when snapshot becomes ready (#4061)

* Fix snapshot clone permanently stuck when snapshot is not immediately ready

when cloning from a VolumeSnapshot that is not yet ReadyToUse, the clone populator stops reconciling and never retries. Since no watch re-triggers reconciliation when the snapshot becomes ready, the clone stays stuck in CloneFromSnapshotSourceInProgress permanently

This affects CSI drivers that report RestoreSize before ReadyToUse, creating a window where a clone can be initiated against a snapshot that isn't fully usable yet

requeueing with a short delay when the snapshot is not ready so the controller retries until ReadyToUse becomes true

Signed-off-by: Noam Assouline <nassouli@redhat.com>
Assisted-by: Claude (Cursor)

* Fix clone source watcher for cross-namespace clones

getPopulationSourceNamespace only checked DataSourceRef.Namespace to determine the source namespace, but for cross-namespace clones CDI leaves that field nil and stores the source namespace in the AnnDataSourceNamespace annotation instead.
This caused the PVC to be indexed under its own namespace rather than the source namespace, preventing the clone source watcher from finding it.

Check AnnDataSourceNamespace first before falling back to DataSourceRef.Namespace.

Signed-off-by: Noam Assouline <nassouli@redhat.com>
Assisted-by: Claude (Cursor)

---------

Signed-off-by: Noam Assouline <nassouli@redhat.com>

16 of 26 new or added lines in 4 files covered. (61.54%)

14782 of 29912 relevant lines covered (49.42%)

0.55 hits per line