Alan-Jowett / sonde / 23701702979

82%

push

github

gateway: sustained health poll failures trigger modem reconnect (#564)

* gateway: sustained health poll failures trigger modem reconnect

After N consecutive poll_status() failures (default 3), the health
monitor now logs at ERROR and returns \	rue\ to signal the caller that
a modem reconnect is needed. The failure counter resets on any
successful poll.

Changes:
- Add \DEFAULT_MAX_HEALTH_POLL_FAILURES\ constant (3)
- Add \max_consecutive_failures\ parameter to \spawn_health_monitor\
- Change return type from \JoinHandle<()>\ to \JoinHandle<bool>\
- Update gateway binary call site to pass the new parameter and
  handle the reconnect signal
- Add T-1104c integration test
- Update GW-1103 requirements, design, and validation docs

Fixes #557

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* address review: validate max_consecutive_failures=0 and use saturating_add

- Return false (disable monitor) when max_consecutive_failures is 0,
  mirroring the existing interval-is-zero guard
- Use saturating_add(1) to prevent u32 overflow on the failure counter

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(gateway): health monitor returns false when disabled (max_failures=0)

When `max_consecutive_failures` is 0, the health monitor now returns
`false` (no reconnect needed) instead of completing immediately and
inadvertently triggering the reconnect path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

11 of 23 new or added lines in 2 files covered. (47.83%)

23228 of 27097 relevant lines covered (85.72%)

155.88 hits per line