Alan-Jowett / sonde / 23700857073

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: gateway force-exits after 5s shutdown timeout (GW-1400) (#563)

* fix: gateway force-exits after 5s shutdown timeout (GW-1400)

The gateway process could hang indefinitely after receiving a shutdown
signal when the USB-CDC serial port was in an error state (e.g. OS
error 22). The serial port \Drop\ impl or a background reader task
would block on a pending I/O operation, preventing the process from
exiting.

Changes:

- docs/gateway-requirements.md: add GW-1400 (bounded shutdown time)
  requiring the gateway to exit within 5 seconds of a shutdown signal.
- docs/gateway-design.md: document the shutdown watchdog in §16.1.
- bin/gateway.rs: after \un_gateway\ returns, spawn an OS thread
  that sleeps for 5 seconds and calls \std::process::exit(0)\. This
  covers both console mode (\main\) and Windows service mode
  (\service_entry\). If the tokio runtime teardown completes
  normally, the watchdog thread is silently reaped by the OS on
  process exit.

Fixes #551

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: align shutdown-timeout design with std::thread implementation

Update §16.1 to describe the actual OS-thread watchdog mechanism
instead of the incorrect \	okio::time::timeout\ / \	okio::spawn\
description. Fix the doc comment on \spawn_shutdown_watchdog()\ to
match.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: align GW-1400 design and requirements with post-un_gateway watchdog

The watchdog is spawned after un_gateway returns, covering runtime
teardown (Drop impls, pending I/O). Update both gateway-design.md and
gateway-requirements.md to reflect that the 5-second deadline starts
after the graceful shutdown completes and \\gateway stopped\\ is
logged, not from signal receipt.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Coverage Stats

0 of 10 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

23197 of 27081 relevant lines covered (85.66%)

155.94 hits per line