Alan-Jowett / sonde / 23693546329

82%

push

github

Gateway: persist ESP-NOW channel in database (GW-0808) (#561)

* feat(gateway): persist ESP-NOW channel in database (GW-0808)

Fixes three related bugs where the ESP-NOW radio channel was ephemeral:

- #558: set-channel was lost on gateway restart
- #555: modem reconnect restored cli.channel instead of last-set channel
- #541: BLE pairing sent cli.channel instead of the current channel

Changes:

**Spec updates (requirements, design, validation):**
- Add GW-0808 requirement for channel persistence
- Update GW-1103 to reference persisted channel on reconnect
- Document gateway_config table and get_config/set_config in design
- Add test cases T-0815a through T-0815e for channel persistence

**Code changes:**
- Add gateway_config table to SQLite schema with migration
- Add get_config/set_config to Storage trait, InMemoryStorage,
  and SqliteStorage
- SetModemChannel admin RPC now writes the new channel to the database
  after a successful modem channel change
- Gateway startup seeds the database with --channel only if no
  persisted value exists; otherwise the database value wins
- Modem reconnect reads the channel from the database on each iteration
- BLE pairing reads the channel from the database on each
  REGISTER_PHONE event

Closes #558
Fixes #555
Fixes #541

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: fail RPC early when DB read fails for channel rollback

The \get_config\ call used \.ok().flatten()\ which silently swallowed
storage errors. If the DB read failed, the modem channel could be
changed without a valid rollback value, breaking the modem+DB
consistency guarantee required by GW-0808.

Return an internal error immediately if the DB cannot be read, before
touching the modem.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

38 of 62 new or added lines in 3 files covered. (61.29%)

23122 of 26981 relevant lines covered (85.7%)

156.43 hits per line