Alan-Jowett / sonde / 23688592383

80%

push

github

node: accept map_type 0 (global variable maps) in validate_map_defs (#547)

* node: accept map_type 0 (global variable maps) in alidate_map_defs

alidate_map_defs() rejected programs containing .rodata/.data global
variable maps (map_type 0) because it only accepted BPF_MAP_TYPE_ARRAY (1).
After PR #539 fixed the gateway to include these maps in program images, the
node started receiving them but rejecting them on install.

Global variable maps are functionally identical to single-entry arrays — they
carry initial data from ELF sections.  Accept map_type 0 alongside type 1.

Changes:
- Add BPF_MAP_TYPE_GLOBAL_VARIABLE constant (0) in map_storage.rs
- Update alidate_map_defs to accept both map_type 0 and 1
- Add tests: 	est_validate_accepts_global_variable_map_type_0 (T-N617),
  	est_validate_rejects_unsupported_map_type (T-N618)
- Update
ode-requirements.md (ND-0606): document accepted map types
- Update
ode-design.md (§9.2, §9.3): document map_type 0 handling
- Update
ode-validation.md: add T-N617, T-N618 and traceability entries

Fixes #544

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* address review: fix test ID collision, wording, and update coverage

- Renumber new test IDs to T-N619/T-N620 to avoid collision with
  existing T-N617/T-N618 labels on `apply_initial_data` tests
- Reword ND-0606 description: 'stored identically as array maps'
  instead of 'single-entry arrays' since BPF_MAP_TYPE_ARRAY supports
  multi-entry maps
- Add `update()` call to `test_validate_accepts_global_variable_map_type_0`
  so it covers both lookup and write paths per T-N619 procedure
- Update traceability tables in node-validation.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* address review: log map_type in error path, use constant in test

- Log unsupported map_type value and index via log::warn! before
  returning the static error, aiding field debugging without
  heap-allocating in the error path (embedded... (continued)

38 of 40 new or added lines in 1 file covered. (95.0%)

23084 of 26924 relevant lines covered (85.74%)

157.2 hits per line