agama-project / agama / 23627356729

77%

master: 77%

push

github

refactor(web): adopt TanStack Form composition pattern in network sub-components

IpSettings, BindingModeSelector, and DeviceSelector previously used
useFormContext(), which is designed for generic leaf field components
and is deliberately untyped. Since these components render slices of a known
form, withForm() is the correct fit. The mismatch forced "as any" casts on
every field name and subscribe selector, silently bypassing TypeScript's
checks and leaving field renames undetected at compile time.

Rewriting the three components with withForm() removes all "as any"
casts and restores full type safety. The form options were extracted from
ConnectionForm using formOptions() and exported to allow sub-components
spread it in their withForm() definition for type inference.

Also, a convenience mergeFormDefaults helper has been added for handling
the case where some defaults depend on runtime hook values and cannot be
declared statically.

3343 of 5314 branches covered (62.91%)

Branch coverage included in aggregate %.

48 of 48 new or added lines in 5 files covered. (100.0%)

12966 of 17078 relevant lines covered (75.92%)

76.63 hits per line