nats-io / nats.go / 23549883071

85%

Build Type

push

github

Committed by web-flow

Commit Message

[IMPROVED] Wrap EOF/connection reset errors with TLS context after handshake (#2031)

* Wrap EOF/connection reset errors with TLS context after handshake

When a TLS proxy (e.g. nginx with mTLS) completes the TLS handshake but
then closes the connection due to an untrusted client certificate, the
client would receive a bare "EOF" or "connection reset by peer" with no
indication that TLS was involved. This wraps such errors with context:

  "nats: connection closed by remote after TLS handshake: EOF"

The wrapped error preserves the original via %w for backwards
compatibility (errors.Is(err, io.EOF) still returns true).

Signed-off-by: Waldemar Quevedo <wally@nats.io>

* Wrap TLS errors in ErrTLS

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>

---------

Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Co-authored-by: Piotr Piotrowski <piotr@synadia.com>

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

8 existing lines in 3 files now uncovered.

14581 of 17067 relevant lines covered (85.43%)

31532.78 hits per line