nats-io / nats.go / 23545171746

85%

Build Type

push

github

Committed by web-flow

Commit Message

[FIXED] WebSocket close frame discarding buffered data frames (#2032)

When a NATS server rejects a WebSocket connection (e.g., due to an
expired JWT), it sends a -ERR protocol message followed by a WebSocket
close frame. If both frames arrive in the same TCP read, the
websocketReader.Read() method would process the close frame and
immediately return io.EOF, discarding the -ERR data that had already
been buffered in the pending list.

This caused nats.Connect to return a generic EOF error instead of the
proper authentication error (ErrAuthorization, ErrAuthExpired, etc.),
making it difficult for users to diagnose connection failures.

The fix defers the close frame's io.EOF when there is already pending
data, storing it in a new closeErr field. The pending data is returned
first, and the deferred error is returned on the subsequent Read() call.

Signed-off-by: Waldemar Quevedo <wally@nats.io>

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

14568 of 17055 relevant lines covered (85.42%)

32472.97 hits per line