kobotoolbox / kpi / 23546667414

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(api): fixes for asset metadata (#6864)

### 📣 Summary
Fix incorrect counts in asset list metadata.


### 📖 Description
Fixes two bugs:
1. The /metadata endpoint was including all public assets, even those
not owned by the requesting user
2. The `metadata` field in the asset list (included when `?metadata=on`
is provided) was always returning an empty country list


### 💭 Notes
There are other in the AssetViewSet besides `list` (in particular the
`/metadata` endpoint) for which we don't want to load all public assets,
which are used in the `detail` views for permission checks.


### 👀 Preview steps

1. ℹ️ have at least two accounts, UserA and UserB
3. Create a project as UserA with a country, sector, and some languages
4. Create a project as UserB with a different country, sector, and
languages
5. Make UserB's project publicly viewable
6. Login as UserA
7. Navigate to `/api/v2/assets/metadata`
8. 🔴 [on main] the `countries` field is empty, and the `sectors` and
`languages` fields include those of UserB's asset
9. 🟢 [on PR] the `countries` field contains the correct country for
UserA's project and UserB's asset information is not present in the
other fields

Coverage Stats

7760 of 11939 branches covered (65.0%)

2 of 14 new or added lines in 2 files covered. (14.29%)

23 existing lines in 4 files now uncovered.

29537 of 35926 relevant lines covered (82.22%)

5.8 hits per line