stacklok / toolhive / 23542795780

65%

Build Type

push

github

Committed by web-flow

Commit Message

Wire git resolver into skill install flow (#4338)

* Wire git resolver into skill install flow

The gitresolver package was fully implemented but not connected to the
main install path. This change integrates it so users can install skills
from git repositories via direct references or registry fallback.

Changes:
- Add WithGitResolver option and installFromGit method to skillsvc
- Detect git:// prefix in Install() before OCI reference check
- Extend resolveFromRegistry to handle "git" package types alongside OCI
- Add dev-mode SSRF bypass in validateHost for E2E testability
- Generate mock for gitresolver.Resolver interface
- Add unit tests for all git install paths (fresh, upgrade, no-op, errors)
- Add E2E tests with local dumb-HTTP git server infrastructure

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Reduce cyclomatic complexity in skill install functions

Extract helpers to bring Install, installFromGit, and resolveFromRegistry
below the gocyclo threshold of 15:
- installByName: plain-name install flow from Install
- installFromRegistryLookup: registry resolution dispatch
- applyGitInstall: store check + create/upgrade branching
- writeAndPersistGitSkill: shared write + persist logic
- resolveRegistryPackages: OCI/git package selection

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Roll back DB record on group registration failure and add missing tests

If registerSkillInGroup fails after a successful install, the skill was
left installed on disk and in the DB but not added to the expected group.
Add installAndRegister helper that wraps all five call sites with a
best-effort store.Delete rollback so retries start fresh.

Add unit tests for validateHost dev-mode SSRF bypass, git reference
URL conversion edge cases, and group registration rollback behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Extract repeated commit hash string into test constant

Fixes gocon... (continued)

Run Details

204 of 237 new or added lines in 4 files covered. (86.08%)

8 existing lines in 3 files now uncovered.

51407 of 78716 relevant lines covered (65.31%)

71.72 hits per line