stacklok / toolhive / 23541869769

65%

Build Type

push

github

Committed by web-flow

Commit Message

Inject run config store into WorkloadFromContainerInfo (#4342)

* Inject run config store into WorkloadFromContainerInfo

WorkloadFromContainerInfo called loadRunConfigFields which internally
created a real state.LocalStore hitting the XDG filesystem on every
call. This caused flaky tests when parallel tests created or truncated
runconfig files, leading to intermittent EOF errors from json.Decode.

Add a state.Store parameter to WorkloadFromContainerInfo and
loadRunConfigFields so callers inject the store, matching the existing
dependency injection pattern in fileStatusManager. Add a runConfigStore
field to runtimeStatusManager for parity.

Fix file_status_test.go mock readers to use DoAndReturn for fresh
readers on each call, preventing EOF when the store is read more than
once per test.

Fixes #4341

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix lint errors in loadRunConfigFields and mergeHealthyWorkloadData

Check reader.Close error return and break long function signature line
to satisfy errcheck and lll linters.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Eliminate TOCTOU race and fix close error handling in loadRunConfigFields

The Exists+GetReader sequence had a race where a concurrent workload
deletion between the two calls would return an error instead of the
intended empty config. Remove the Exists call entirely and handle
not-found from GetReader directly via httperr status code.

Also log reader.Close() errors with slog.Warn to match the established
project pattern, and wrap errors with workload name for debuggability.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix gci import grouping in types.go

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Inject run config store into NewStatusManagerFromRuntime

Move store creation out of NewStatusManagerFromRuntime into
NewStatusManagerWithEnv so the constructor is pure DI. Tests
inject a... (continued)

Run Details

28 of 38 new or added lines in 3 files covered. (73.68%)

40 existing lines in 3 files now uncovered.

51240 of 78515 relevant lines covered (65.26%)

72.14 hits per line