agama-project / agama / 23539550325

64%

master: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Add the internal device id to the updated device (bsc#1247445). (#2680) (#3326)

Original fix and description from #2680 backported to SLE-16 branch

When a zFCPController is activated the UI is not refreshed properly
maintaining it as inactive

- https://trello.com/c/5SeUZvuG
- https://bugzilla.suse.com/show_bug.cgi?id=1247445

The problem is that the changed device does not contain its id,
therefore we are not replacing it at all. For refreshing the **zFCP**
Controllers table, just notifying the device id and replacing the object
should be enough, but we need to retrieve also the disks associated with
the activated controller and this is done through the controllers query,
therefore, we invalidate it after any controllers change.

The only thing that could be improved is that it takes some time to get
the list of LUNs and the controllers selector updated.

- *Tested manually*

**Update**: In recent changes it has been also reported that when a
controller is activated apart of the controller **LUNs** the disks table
is populated with the other controller **LUNs**. The problem is that
retrieving the controllers also tries to get the luns of each controller
through the **zfcp_san_disc** which activates temporally the controller
in question. We should get only the LUNs for the active controllers and
that is what has been also implemented.

Run Details

2228 of 4007 branches covered (55.6%)

Branch coverage included in aggregate %.

1 of 13 new or added lines in 3 files covered. (7.69%)

9 existing lines in 2 files now uncovered.

25573 of 39151 relevant lines covered (65.32%)

50.0 hits per line