ArduPilot / MethodicConfigurator / 23533740398

94%

push

github

fix(upload): replace recursive retry with iterative loop in upload_selected_params_workflow

The recursive retry path had three bugs:

1. Missing get_connection_progress_callback argument — the download
   callback factory was passed in position 7 (where connection callback
   belongs), causing wrong progress text on retry and no download
   progress at all.

2. Unbounded recursion — each retry added a stack frame, risking
   RecursionError on persistent FC communication issues.

3. Redundant side effects — _write_current_file() and the
   _at_least_one_changed reset executed once per recursion depth
   on unwind, not just once.

Replace with a while loop that re-runs the entire upload/validate
cycle on retry. All callback factories are now correctly re-invoked
each iteration, _write_current_file() runs exactly once after the
loop exits.

Closes #1427

Signed-off-by: Yash Goel <yashhzd@users.noreply.github.com>

1682 of 1749 branches covered (96.17%)

11085 of 11812 relevant lines covered (93.85%)

3.74 hits per line