Alan-Jowett / sonde / 23522547944

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(gateway,node): preserve ChunkedTransfer session on WAKE retry (#487)

* fix(gateway,node): preserve ChunkedTransfer session on WAKE retry

Spec (GW-0602):
- AC5: WAKE retry with same nonce reuses existing ChunkedTransfer
  session instead of creating a new one.

Spec (ND-0702):
- Response timeout increased from 50ms to 200ms to account for
  USB-CDC modem bridge round-trip latency.
- Retry delay increased from 100ms to 400ms.

Spec (ND-1011):
- New requirement for GET_CHUNK/CHUNK logging at DEBUG level.

Gateway (engine.rs):
- Check if existing session is ChunkedTransfer with matching nonce
  before creating a new session on WAKE.
- If reusing, re-send the same COMMAND from the existing transfer.

Node (wake_cycle.rs):
- RESPONSE_TIMEOUT_MS: 50 -> 200
- RETRY_DELAY_MS: 100 -> 400
- Add DEBUG logging for GET_CHUNK sent and CHUNK received.

Fixes #468.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: use existing session starting_seq on WAKE retry, add T-0607a test

Address review findings for PR #487:

1. (Critical) When `reuse_chunked` is true, the COMMAND response now
   uses the existing session's `next_expected_seq` instead of a newly
   generated random `starting_seq`. This ensures GET_CHUNK sequence
   verification succeeds after a WAKE retry (GW-0602 AC5).

2. (High) Added integration test `t0607a_wake_retry_preserves_chunked_transfer_session`
   validating that a WAKE retry with matching nonce preserves the
   ChunkedTransfer session state and sequence tracking (T-0607a).

3. (Medium) Clarified GW-0602 AC#4 to specify it applies only when no
   ChunkedTransfer session is active, removing the conflict with AC#5.

4. (Medium) Added ND-1011 (Chunk transfer logging) to the Appendix A
   requirement index in node-requirements.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address round-2 review: align timing specs, add integration test, fix comments

- Update ND-0700/ND-0701 retry delay ... (continued)

Coverage Stats

45 of 55 new or added lines in 2 files covered. (81.82%)

1 existing line in 1 file now uncovered.

22153 of 25818 relevant lines covered (85.8%)

163.44 hits per line