Alan-Jowett / sonde / 23522479144

82%

push

github

fix(gateway): share pending_commands when handler config is used (#488)

* fix(node): remove RngHealthCheckFailed match arm from firmware binary

The RngHealthCheckFailed enum variant was removed during the PR #418
merge resolution -- RNG health-check failure now returns
WakeCycleOutcome::Sleep (graceful degradation). The bin/node.rs match
arm referencing the removed variant was auto-merged from the PR branch
and breaks the ESP32 firmware build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(gateway): share pending_commands when handler config is used

Design (§9.1):
- Document that --handler-config must use new_with_pending +
  set_handler_router to share pending_commands with admin API (D-485).

Code:
- Add Gateway::set_handler_router() method.
- gateway.rs: use new_with_pending + set_handler_router instead of
  new_with_handler when --handler-config is provided.

Fixes #485.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review findings: guard set_handler_router against double-set, strengthen D-485 design note

- Add assert in set_handler_router to prevent accidental double-init
- Strengthen gateway-design.md D-485 note to explicitly forbid constructors
  that create separate pending_commands maps

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: return Result from set_handler_router, clarify new_with_handler scope

- Replace assert! in set_handler_router with Result<(), &'static str>
  so a double-set returns an error instead of panicking in production.
- Add doc warning on new_with_handler noting it allocates its own
  pending_commands/SessionManager and is test-only (D-485).
- Update gateway-design.md D-485 note to accurately describe the
  current API contract and new_with_handler limitations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <... (continued)

0 of 15 new or added lines in 2 files covered. (0.0%)

22125 of 25781 relevant lines covered (85.82%)

162.99 hits per line