Alan-Jowett / sonde / 23516142523

82%

push

github

fix: emit pf_trace_printk at INFO and log I/O helpers at DEBUG (#478)

* fix: emit pf_trace_printk at INFO and log I/O helpers at DEBUG

Fixes #475 — BPF trace output and helper call logging not visible at
the default ESP-IDF log level.

Spec changes (ND-1006, ND-1010):
- ND-1006: added acceptance criterion that pf_trace_printk output
  MUST be emitted at INFO level.
- ND-1010: new requirement — I/O helpers (send, send_recv, i2c_write,
  i2c_write_read, gpio_read, gpio_write, adc_read, bus_transfer)
  SHOULD be logged at DEBUG level with helper name and return value.
- Updated node-design.md log level table and log points.
- Added validation test cases T-N1014 and T-N1015.

Code changes:
- wake_cycle.rs: changed \pf_trace_printk\ flush from \log::debug!\
  to \log::info!\.
- bpf_dispatch.rs: added \log::debug!\ after each I/O helper call
  with helper name and result.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review findings for PR #478

- Fix T-N1014 step 4: assert log entry is tagged at INFO level instead
  of asserting absence at DEBUG (which includes INFO output)
- Fix T-N613 step 2: same assertion rewording for consistency
- Fix T-N1015: add step to enable DEBUG-level logging before asserting
  DEBUG output (ESP-IDF defaults to INFO)
- Fix ND-1010 and bpf_dispatch.rs: rename \us_transfer\ to
  \spi_transfer\ to match canonical helper name
- Update log volume guidance in node-design.md to account for
  INFO-level \pf_trace_printk\ output

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address round-2 review: add i2c_read to ND-1010, add debug log, add tests

- Include i2c_read in ND-1010 helper list and T-N1015 procedure
  (was omitted despite being an I/O helper)
- Add DEBUG log to helper_i2c_read matching other I/O helpers
- Extract lush_trace_log for testability
- Add shared 	est_log_capture module for log-level assertions
- Add tests: i2c_read DEBUG log, gpio_read DEBUG log... (continued)

186 of 190 new or added lines in 3 files covered. (97.89%)

21950 of 25581 relevant lines covered (85.81%)

164.25 hits per line