Alan-Jowett / sonde / 23516126016

82%

push

github

fix: use sonde-specific Prevail verifier platform (GW-0404) (#480)

* fix: use sonde-specific Prevail verifier platform (GW-0404)

Replace `LinuxPlatform` with `SondePlatform` for BPF program
verification. Linux BPF assigns different semantics to helper IDs 1-16
than sonde does, causing programs that call sonde helpers (`i2c_read`,
`gpio_write`, `send`, etc.) to fail verification or be verified
under incorrect helper semantics.

`SondePlatform` defines helper prototypes for all 16 sonde BPF helpers
matching the signatures in `test-programs/include/sonde_helpers.h`.
It wraps `LinuxPlatform` via composition for ELF/map parsing and
overrides helper-related methods.

Spec updates:
- GW-0404 requirement added to gateway-requirements.md
- SondePlatform design section added to gateway-design.md
- T-0408/T-0409 test cases added to gateway-validation.md

Fixes #474

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Address review findings: section_prefixes, doc wording

- Add "sonde" to section_prefixes so SEC("sonde") ELF programs are
  recognized by Prevail (GW-0404).
- Tighten GW-0404 AC#4 wording: LinuxPlatform is not passed directly
  as the verifier platform; SondePlatform may compose it for ELF/map
  parsing.
- Clarify T-0409 step 2: assert SondePlatform is used for verification;
  LinuxPlatform encapsulated inside is acceptable.
- Add test assertion for "sonde" in section_prefixes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test: add SondePlatform helper verification integration tests

Add two tests proving that \SondePlatform\ correctly recognises
sonde-specific BPF helpers during \ingest_elf()\ verification:

- \ingest_elf_with_sonde_helper_succeeds\: hand-crafted ELF with
  \call 3\ (\i2c_write_read\) — a helper with no Linux equivalent.
- \ingest_elf_with_sonde_helper_8_succeeds\: hand-crafted ELF with
  \call 8\ (\send\) — the primary transmi... (continued)

211 of 237 new or added lines in 2 files covered. (89.03%)

21751 of 25411 relevant lines covered (85.6%)

162.53 hits per line