dnsimple / erldns / 23504158941

87%

Build Type

push

github

Committed by web-flow

Commit Message

Fix restart_delegated_query to always find the correct authoritative zone (#341)

`restart_delegated_query/7` had two bugs:

1. The `true` (InZone) branch blindly reused the caller's Zone instead
   of finding the actual authoritative zone for the labels.

2. The `false` branch matched `#zone{} = Zone` where Zone was already
   bound from the function head, so it could only match the *same* zone
   — a different zone caused a case_clause crash, and the
   `not_authoritative` return was unhandled.

Both bugs were latent because `maybe_add_zonecut_records` normalises
delegation responses to referrals, masking the inner result.

Changes:
- Replace `restart_delegated_query/7` with `/5`: drop `Zone` and
  `InZone` parameters, always call `get_authoritative_zone/1` with a
  fresh binding. Note also that the `InZone` parameter would do an ETS
  traversal that is redundant with the next ETS traversal getting the
  zone.
- Remove redundant restart at NS delegation points (first clause of
  resolve_exact_type_match for NS with no SOA) — return the message and
  let maybe_add_zonecut_records produce the referral
- Drop Msg parameter from maybe_add_zonecut_records so the original
  message can be GC'd before the zone-cut check runs

Run Details

2 of 4 new or added lines in 1 file covered. (50.0%)

7 existing lines in 1 file now uncovered.

1714 of 1982 relevant lines covered (86.48%)

1853.16 hits per line