wol-soft / php-json-schema-model-generator / 23489999208

99%

master: 99%

Build Type

Pull #121

github

Committed by Enno Woortmann

Commit Message

Strengthen ComposedRequiredPromotion test coverage

- Assert specific composition exception types (AllOfException,
  AnyOfException, OneOfException, ConditionalException) in CanBeOmitted
  tests instead of the generic Exception base class
- Assert assertInstanceOf on the collected error in all three
  implicit-null error-collection tests; add allOf and oneOf variants
  of that test (previously only anyOf was covered)
- assertNullableStringProperty/assertNullableIntProperty now
  unconditionally assert null is present: composition-transferred
  non-promoted properties are always nullable regardless of implicitNull,
  and this is now verified in both modes rather than only under
  implicitNull=true
- Add testMultiplePropertiesOnlySomePromoted: two transferred properties
  where only one meets the promotion condition
- Cover three defensive guard paths in the post processor with new
  schemas and tests: AnyOfEmptyComposition (empty branches array),
  AnyOfRequiredOnlyBranches (required name absent from schema properties),
  and AnyOfUntypedPropertyInBranches (getType() returns null, no promotion)

Pull Request Pull Request #121: Add composition required promotion and fix allOf untyped-branch type erasure

Coverage Stats

55 of 56 new or added lines in 3 files covered. (98.21%)

3943 of 4000 relevant lines covered (98.58%)

573.62 hits per line