wol-soft / php-json-schema-model-generator / 23486015113

99%

master: 99%

Build Type

Pull #121

github

Committed by Enno Woortmann

Commit Message

Add composition required promotion and fix allOf untyped-branch type erasure

When a property is guaranteed present by composition constraints, promote
it to non-nullable in the generated type hint (nullable=false) without
changing isRequired(), so template short-circuit behaviour is preserved.

Promotion rules (via new CompositionRequiredPromotionPostProcessor):
- allOf: required in any branch → promote (all branches hold simultaneously)
- anyOf/oneOf: required in every branch → promote (matching branch always provides it)
- if/then/else: required in both then and else → promote (one always applies)

Also fixes a bug in PropertyMerger where a truly-untyped allOf branch
(no 'type' keyword) incorrectly wiped the type from a typed sibling
branch. For allOf, an untyped branch adds no type constraint.

Pull Request Pull Request #121: Add composition required promotion and fix allOf untyped-branch type erasure

Coverage Stats

53 of 56 new or added lines in 3 files covered. (94.64%)

3941 of 4000 relevant lines covered (98.53%)

571.29 hits per line