MushroomObserver / mushroom-observer / 23461633071

96%

main: 96%

Build Type

Pull #3988

github

Committed by mo-nathan

Commit Message

Implement Phase 11: review affected areas and project membership

Phase 11 review:
- Project observation counts use visible_observations (exclude
  non-primary) for tab counts, checklist, constraint checks, and
  location counts
- Site statistics observation/taxa counts exclude non-primary
- Nightly cache refresh for occurrence.has_specimen added to
  script/refresh_caches
- Report classes and RSS log queries already correct

Project membership gap detection:
- When creating an occurrence or adding observations via field slip,
  detect when observations belong to different sets of projects
- Show a modal (Cancel/Add All) on top of the current page offering
  to add all observations to all projects
- OccurrenceResolveModal and OccurrenceResolveForm Phlex components
- Works on Occurrence New, Occurrence Edit, Field Slip New, and
  Field Slip Edit pages
- Occurrence::ProjectGaps concern for gap detection and resolution

Field slip logging:
- "Added to field slip [code] by [user]." log entries when
  observations are added via field slip
- "Removed from field slip [code] by [user]." on removal
- "Field slip [code] updated by [user]." on primary touch
- Occurrence::Logging concern extracts all logging/notification
  class methods from Occurrence model

Other fixes:
- Destroy occurrence uses can_edit? (any user) instead of
  creator-only check
- Occurrence.dissolve! preserves occurrence when field slip linked,
  reducing to primary-only instead of destroying
- API POST rejects observations from multiple existing occurrences

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #3988: Add Occurrence model and migration (#3808)

Run Details

1475 of 1580 new or added lines in 55 files covered. (93.35%)

4 existing lines in 3 files now uncovered.

35790 of 37298 relevant lines covered (95.96%)

659.07 hits per line