zopefoundation / Products.CMFCore / 23461348830

86%

master: 87%

Build Type

Pull #160

github

Committed by jensens

Commit Message

Fix: ensure site manager is active during queue processing

When the indexing queue is processed outside a request context
(e.g. in the before_commit transaction hook), getSite() returns
None. IndexableObjectWrapper then falls back to the global site
manager, which lacks locally registered indexer adapters. This
causes attributes like exclude_from_nav to silently not be indexed.

Previously masked because processQueue() was called mid-request
(via reindexObjectSecurity -> unrestrictedSearchResults) when the
site was always set. Since #155 bypasses processQueue in
reindexObjectSecurity, more operations are deferred to
before_commit where the site may not be set.

Fix: PortalCatalogProcessor._ensure_site() walks the object's
acquisition chain to find and activate a site before each catalog
operation.

Refs: plone/buildout.coredev#1080

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #160: Fix: ensure site manager is active during queue processing

Coverage Stats

1937 of 3054 branches covered (63.43%)

Branch coverage included in aggregate %.

2 of 16 new or added lines in 1 file covered. (12.5%)

3 existing lines in 1 file now uncovered.

17580 of 19526 relevant lines covered (90.03%)

0.9 hits per line