Alan-Jowett / sonde / 23460872035

81%

push

github

test(modem): add BLE indication flow control, Write Long, and TX backpressure tests (#416)

* test(modem): add BLE indication flow control, Write Long, and TX backpressure tests

Add 13 tests covering three untested gaps identified in #338:

GAP 1 — MD-0403 AC3: Indication fragmentation flow control
- `FragmentingMockBle` mock that simulates ATT indication pacing
  with `awaiting_confirm` flag and per-chunk confirmation gating
- `t0605_indication_flow_control_awaits_confirm`: 3-chunk payload,
  verify one chunk per confirmation cycle
- `t0605_indication_chunks_within_mtu_limit`: all chunks <= MTU-3
- `t0605_indication_single_chunk_no_fragmentation`: small payload
- `t0605_indication_exact_mtu_boundary`: payload exactly MTU-3
- `t0605_advance_indication_blocked_while_awaiting_confirm`: 10
  polls without confirm, no advance
- `t0605_fragmenting_ble_empty_indicate_discarded`: empty data

GAP 2 — MD-0409 AC2: Write Long reassembly
- `t0613_write_long_reassembled_as_single_ble_recv`: 500-byte
  payload forwarded as single BLE_RECV
- `t0613_ble_recv_payload_forwarded_unmodified`: all 256 byte
  values bit-exact
- `t0613b_empty_gatt_write_no_ble_recv`: no event = no output
- `t0613_multiple_write_longs_separate_ble_recv`: two large writes
  arrive as two distinct BLE_RECV messages

GAP 3 — Design §4.3: USB TX backpressure
- `tx_backpressure_drops_frames_no_crash`: 32 radio frames with
  rejected writes, no crash, rx_count stays 0
- `tx_backpressure_recovery`: bridge resumes normal forwarding
  after write failures clear
- `tx_backpressure_ble_events_no_crash`: BLE events under
  backpressure, bridge recovers

Closes #338

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address review feedback in BLE flow control tests

- Add #[allow(dead_code)] on unused FragmentingMockBle fields to avoid clippy warnings

- Add assertions in t0613b_empty_gatt_write_no_ble_recv to validate actual behavior after empty BleEvent::Recv injection

Co-... (continued)

347 of 367 new or added lines in 1 file covered. (94.55%)

20727 of 24179 relevant lines covered (85.72%)

169.31 hits per line