Alan-Jowett / sonde / 23460374229
81%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 74
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.587% (+0.01%) from 85.575%
23460374229

push

github

web-flow 
test(protocol): close remaining validation gaps (#414)

* test(protocol): close remaining validation gaps (#356)

Add 5 tests covering the 3 remaining gaps from issue #356:

- T-P066: Verify \erify_frame\ delegates to \HmacProvider::verify\
  (constant-time path), not \compute\ + \==\. Uses a tracking
  provider to assert \erify()\ is called for valid, invalid-key,
  and tampered-tag scenarios.

- T-P048: Verify \ProgramImage::encode_deterministic\ uses RFC 8949
  §4.2 minimal-length integer encoding. Tests boundary values (23 →
  1-byte, 24 → 2-byte, 256 → 3-byte), inspects raw CBOR byte
  sequences, and asserts byte-identical output to ciborium reference
  encoder with exact byte-length check.

- T-P049a: \ProgramImage::decode\ rejects truncated CBOR (0 bytes,
  1 byte, half-length) with \DecodeError::CborError\.

- T-P049b: \ProgramImage::decode\ returns \MissingField(IMG_KEY_BYTECODE)\
  when the bytecode field is absent.

- T-P049c: \ProgramImage::decode\ returns correct errors for wrong
  field types (bytecode as integer, maps as integer, map entry as
  text, nested map_type as text, top-level array instead of map).

Gaps 2 (ProgramAck/RunEphemeral/Reboot round-trips), 5 (decode_frame
TooLong), and 6 (unknown keys on Command) were already covered by
tests added in PRs #391–#406.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address review feedback in protocol validation tests

- Delegate TrackingHmac compute/verify to SoftwareHmac to eliminate code duplication

- Move Cell import to top-level imports

- Reorder tests by T-P number (T-P048/049 before T-P066)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address review feedback on protocol test gaps

- Remove redundant has_seq byte subsequence checks and hardcoded
  length assertion, keeping only the reference-encoder comparison
- Clarify MAP_KEY_TYPE wrong-type test comment: decoder treats
  non-integer values as missing (MissingFi... (continued)

20380 of 23812 relevant lines covered (85.59%)

171.55 hits per line

Jobs
ID Job ID Ran Files Coverage
1 23460374229.1 74
85.59
 GitHub Action Run
Source Files on build 23460374229