agama-project / agama / 23446121314

77%

push

github

service: Fix wrong check when searching or creating a storage device (#3322)

## Problem

As reported at #2985.

When searching for a device with the setting `{ "ifNotFound": "create"
}`, Agama was reporting an error if the device was not found.

Actually, the mechanism to create the missing device is in place, but
the overzealous check was causing the rest of the process to be aborted
so it was not even attempted.

## Solution

This fixes #2985 by improving the check. Now it takes the case of `{
"ifNotFound": "create" }` into account.

## Testing

- Added a new unit test to the config checker
- Added a couple of regression test to prove the devices can actually be
created if not found

In fact, this PR is a small fix... with several lines of extra tests to
verify.

3251 of 5221 branches covered (62.27%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

20649 of 25845 relevant lines covered (79.9%)

86.7 hits per line