agama-project / agama / 23439396413

77%

master: 77%

push

github

refactor(web): reimplement network connection form using TanStack Form (part 1) (#3300)

This PR starts the reimplementation of the network connection form using
[TanStack Form](https://tanstack.com/form/latest), replacing the
previous ad-hoc form state management with a structured, library-backed
approach.

## What is included

In order to avoid an endless PR and make it easier to follow for review,
the whole reimplementation will be addressed in multiple PRs against a
feature branch. This first PR covers the following fields:

- Connection name and interface
- IPv4 and IPv6 method and gateway
- IP addresses (single textarea for both protocols, with dynamic label
reflecting the current requirement based on the selected methods)
- DNS servers (hidden behind a checkbox opt-in)
- DNS search domains (hidden behind a checkbox opt-in)

Additionally, two files have been included as part of this PR:

- `src/components/form/LabelText`: a reusable component that renders
text content for a FormGroup label prop, with an optional styled suffix
(e.g. "(optional)") and a hidden prop for fields that need an accessible
label without visible text.
- `src/components/form/conventions.md`: a set of form conventions
documented as patterns arose, covering field visibility patterns, label
suffixes, and accessibility guidance. It should be moved elsewhere after
reaching the master branch, but kept in the newly created form namespace
for now. The idea is to keep it up to date as the project evolves and
form patterns that suit it well arise.

## What is deferred to follow-up PRs

- **Field validation.** No client-side validation is done yet. The
server acts as the validator via `onSubmitAsync`. Empty required fields,
invalid addresses, and required DNS servers when checked will be added
incrementally.
- **Enhanced multi-value input.** IP addresses, DNS servers, and DNS
search domains are currently plain textareas allowing values separated
by space or new lines. These will be r... (continued)

3290 of 5259 branches covered (62.56%)

Branch coverage included in aggregate %.

91 of 93 new or added lines in 4 files covered. (97.85%)

12860 of 16974 relevant lines covered (75.76%)

77.48 hits per line