agama-project / agama / 23436714669

64%

master: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Adapt agama config to return error code when no validates (SLE-16) (#3310)

Same than #3304 but for SLE-16

In contrary to SLE-16.1, in SLE-16 the `agama config load` returns 1 in
both cases when there is no product but continues otherwise.

## Tests

- *Tested manually*

### agama config validate

```bash
agama:~ # agama_not_fix/agama config validate profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

agama:~ # agama_fix/agama config validate profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1
```

### agama config load

```bash
agama:~ # agama_not_fix/agama config load profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

Cannot proceed with profile without specified product
1
agama:~ # agama_fix/agama config load profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('ID' was unexpected). /product
        * "id" is a required property. /product

The profile is not valid
1
agama:~ # agama_not_fix/agama config load profile.json || echo $?
✗ The profile is not valid. Please, check the following errors:

        * Additional properties are not allowed ('test' was unexpected). 

[1/2] Analyze disks
[2/2] Configure software

agama:~ # nmcli c
NAME                UUID                                  TYPE      DEVICE 
Wired connection 1  91b9fecf-4020-35ec-97f8-d8e2cdcff413  ethernet  enp1s0 
Wired connection 2  12b49824-ddaa-3f0f-a73f-ec0f1ccd12ae  ethernet  e... (continued)

Run Details

2228 of 4007 branches covered (55.6%)

Branch coverage included in aggregate %.

0 of 5 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

11972 of 16714 relevant lines covered (71.63%)

70.68 hits per line