#20216
89%

Ran 23 Mar 2026 12:11PM UTC

Jobs 1

Files 630

Run time 1min

Badge

Embed ▾

Committed 23 Mar 2026 11:58AM UTC coverage: 88.7% (+0.01%) from 88.686%

Build # #20216

Build Type

push

github

Committed by

web-flow

Commit Message

core: fix false-positive orphan warning in ManagedChannelOrphanWrapper (#12705)

This PR addresses a race condition where ManagedChannelOrphanWrapper
could incorrectly log a "not shutdown properly" warning during garbage
collection when using directExecutor().

Changes:

Reference Management: Moved phantom.clearSafely() to execute after the
super.shutdown() calls to ensure the orphan tracker isn't detached
prematurely.

Reachability Fence: Added a reachability fence in shutdown() and
shutdownNow() to ensure the wrapper remains alive until the methods
return, preventing the JIT from marking it for early collection.

Regression Test: Added a test case that simulates a reference being held
on the stack to verify the fix and prevent future regressions.

Testing:
Verified with ./gradlew :grpc-core:test --tests
ManagedChannelOrphanWrapperTest -PskipAndroid=true.

Fixes #12641

---------

Co-authored-by: Kannan J <kannanjgithub@google.com>

Run Details

35489 of 40010 relevant lines covered (88.7%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	96.92	-3.08%	../core/src/main/java/io/grpc/internal/ManagedChannelOrphanWrapper.java
4	91.9	-1.9%	../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20216.1	23 Mar 2026 12:11PM UTC	630	88.7

grpc / grpc-java / #20216
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20216

grpc / grpc-java / #20216 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #20216

grpc / grpc-java / #20216
89%

README BADGES
x