Alan-Jowett / sonde / 23363555300

82%

push

github

fix(modem): add BLE pairing timeout, pin ATT MTU, document auto-accept (#393)

* fix(modem): add BLE pairing timeout, pin ATT MTU, document auto-accept

- Add 30-second BLE pairing timeout (MD-0414 AC#4): store
  \connection_start\ timestamp on connect, check elapsed time each
  poll cycle via \check_pairing_timeout()\, force-disconnect if
  exceeded.
- Add \CONFIG_BT_NIMBLE_ATT_PREFERRED_MTU=512\ to
  \sdkconfig.defaults.esp32s3\ to explicitly pin ATT MTU >= 247
  (MD-0402).
- Add \TODO(#382)\ comment documenting that Numeric Comparison is
  auto-accepted due to NimBLE callback constraints; proper fix
  requires gateway-modem serial coordination on a dedicated task.

Closes #382

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: gate pairing timeout on pairing_pending state (MD-0414)

The BLE pairing timeout was enforced unconditionally from connection
time, which could disconnect legitimate post-authenticated sessions
after 30s. Per MD-0414 AC#4, the 30s timeout applies only while
waiting for BLE_PAIRING_CONFIRM_REPLY.

Changes:
- Start the timeout clock when pairing_pending becomes true (on
  passkey display), not at connection time.
- Gate check_pairing_timeout() on pairing_pending so authenticated
  sessions are never affected.
- Clear pairing_pending and connection_start on timeout to prevent
  repeated disconnect attempts and warning spam.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR #393 round 2 review comments

- Start pairing timeout on connect (not on_confirm_pin) so clients that
  never initiate pairing cannot hold the connection slot indefinitely.
  Clear connection_start once authentication completes.
- Clear deferred_connected on timeout and ignore late pairing_confirm_reply
  calls when pairing is no longer pending.
- Rewrite BLE_PAIRING_TIMEOUT doc comment for clarity.
- Add check_pairing_timeout counter to MockBle and a test verifying
  Bridge::poll() calls it onc... (continued)

15 of 15 new or added lines in 1 file covered. (100.0%)

16859 of 20373 relevant lines covered (82.75%)

49.33 hits per line